Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Uninitialized variable in three models #283

Merged
merged 1 commit into from Mar 24, 2016

Conversation

@obreitwi
Copy link

@obreitwi obreitwi commented Mar 22, 2016

<model>::Parameters_::num_of_receptors_ is uninitialized for the three
models:

  • aeif_cond_alpha_multisynapse
  • iaf_psc_alpha_multisynapse
  • iaf_psc_exp_multisynapse

By chance it seems to always be 0 in the current master branch. However,
when compiling modified source code, it can assume aribtrary values.
This leads to potential SEGFAULTs when the calibrate() method is
called on an unchanged node.

`<model>::Parameters_::num_of_receptors_` is uninitialized for the three
models:

 * `aeif_cond_alpha_multisynapse`
 * `iaf_psc_alpha_multisynapse`
 * `iaf_psc_exp_multisynapse`

By chance it seems to always be 0 in the current master branch. However,
when compiling modified source code, it can assume aribtrary values.
This leads to potential SEGFAULTs when the `calibrate()` method is
called on an unchanged node.
@heplesser
Copy link
Contributor

@heplesser heplesser commented Mar 24, 2016

@obreitwi Thanks for catching this! 👍 and merging.

@heplesser heplesser merged commit 9317fe0 into nest:master Mar 24, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.