Fix: Uninitialized variable in three models #283

Merged
merged 1 commit into from Mar 24, 2016

Conversation

Projects
None yet
2 participants
@obreitwi

<model>::Parameters_::num_of_receptors_ is uninitialized for the three
models:

  • aeif_cond_alpha_multisynapse
  • iaf_psc_alpha_multisynapse
  • iaf_psc_exp_multisynapse

By chance it seems to always be 0 in the current master branch. However,
when compiling modified source code, it can assume aribtrary values.
This leads to potential SEGFAULTs when the calibrate() method is
called on an unchanged node.

Fix: Uninitialized variable in three models
`<model>::Parameters_::num_of_receptors_` is uninitialized for the three
models:

 * `aeif_cond_alpha_multisynapse`
 * `iaf_psc_alpha_multisynapse`
 * `iaf_psc_exp_multisynapse`

By chance it seems to always be 0 in the current master branch. However,
when compiling modified source code, it can assume aribtrary values.
This leads to potential SEGFAULTs when the `calibrate()` method is
called on an unchanged node.
@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Mar 24, 2016

Contributor

@obreitwi Thanks for catching this! 👍 and merging.

Contributor

heplesser commented Mar 24, 2016

@obreitwi Thanks for catching this! 👍 and merging.

@heplesser heplesser merged commit 9317fe0 into nest:master Mar 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment