MyModule example now builds, and nest.Install("mymodule") works as expected #328

Merged
merged 8 commits into from May 25, 2016

Conversation

Projects
None yet
2 participants
@markovg
Contributor

markovg commented May 1, 2016

…mbol lookup error: /opt/nest/lib/nest/mymodule.so.0: undefined symbol

markovg added some commits May 1, 2016

MyModule example now builds, but nest.Install("mymodule") throwing sy…
…mbol lookup error: /opt/nest/lib/nest/mymodule.so.0: undefined symbol

@markovg markovg changed the title from MyModule example now builds, but nest.Install("mymodule") throwing sy… to MyModule example now builds, and nest.Install("mymodule") works as expected May 1, 2016

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser May 3, 2016

Contributor

@markovg Thank you for those fixes, they look good. Unfortunately, MyModule building is not covered by our test harness yet, so sometimes things slip through. Your PR can currently not be merged because of conflicts. This is most likely because we recently reformatted all source code to stay within 80 characters line width.

Could you merge the recent changes on the master branch into your branch and thus PR?

Contributor

heplesser commented May 3, 2016

@markovg Thank you for those fixes, they look good. Unfortunately, MyModule building is not covered by our test harness yet, so sometimes things slip through. Your PR can currently not be merged because of conflicts. This is most likely because we recently reformatted all source code to stay within 80 characters line width.

Could you merge the recent changes on the master branch into your branch and thus PR?

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser May 25, 2016

Contributor

Due to overlap with other PRs, this PR now boiled down to formatting fixes in documentation, thus merging without further ado.

Contributor

heplesser commented May 25, 2016

Due to overlap with other PRs, this PR now boiled down to formatting fixes in documentation, thus merging without further ado.

@heplesser heplesser merged commit abe8f72 into nest:master May 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment