Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Changed order of setting parameters for synapse models #333
In #284, I modified the stdp synapse model to allow inhibitory synapses (
While creating a new connection the parameter
For asserting that
@weidel-p It would be very nice to have a regression test showing the problem you solve here. Just to make sure that we do not reintroduce it later.
I am also wondering a little about the logic here.
@heplesser as I metioned above, in #284, I changed the
There are three different ways to set parameters of a synapse:
Please correct me if I'm wrong, but from these three options, only option 2 calls
Anyway, in #284 I want to check for correct signs in all three cases which was not possible so far. I think we don't need a dedicated test to make sure that this issue is not reappearing. As soon as #284 is merged, the tests for the
@weidel-p I agree with your analysis of who calls
I think we need to implement checking the sign of the weight both in