Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of exact integration for nest-simulator site [ci skip] #383

Merged
merged 4 commits into from Jul 11, 2016

Conversation

@ingablundell
Copy link

ingablundell commented Jun 2, 2016

This is just documentation!
This ipython notebook briefly describes exact integration.
@steffengraber This is documentation for the nest-simulator site.
I propose @jougs @heplesser as reviewers

@heplesser
Copy link
Contributor

heplesser commented Jun 19, 2016

@ingablundell Thank you for writing this up! Could you add a section with an explicit example, e.g., the iaf_psc_alpha neuron with two indepedent alpha-function inputs (two different time constants). To really allow readers to connect math and code, it would be great if you would then also relate the equations to their implementation in NEST.

@ingablundell
Copy link
Author

ingablundell commented Jun 20, 2016

OK. I will add the example and try to relate code to math but that will make the documentation more complicated and more difficult to understand:)

@jougs
Copy link
Contributor

jougs commented Jun 24, 2016

@steffengraber: can you please check how/if this could be reformatted as a "normal" markdown file for the documentation? Thanks!

@steffengraber
Copy link
Collaborator

steffengraber commented Jun 24, 2016

@jougs @ingablundell

we can use ipython nbconvert for this:

ipython nbconvert --to markdown notebook.ipynb
ipython nbconvert --to html notebook.ipynb

Looks nice for me.

@ingablundell
Copy link
Author

ingablundell commented Jun 24, 2016

@heplesser I have now added a part with the iaf_psc_alpha as an example

@heplesser
Copy link
Contributor

heplesser commented Jun 29, 2016

👍 from me, @jougs, are you happy as well?

@jougs
Copy link
Contributor

jougs commented Jun 29, 2016

@ingablundell: nice work indeed!

Can you please still do the following things?

  • rename the directory exact_integration to ipynb
  • rename the file Whatisexactintegration.ipynb
    to exact-integration.ipynbin order comply to our conventions
  • change the headline to something like "Integrating neural models using exact integration"
  • Rotter and Diesmann should be linked to http://dx.doi.org/10.1007/s004220050570
@ingablundell
Copy link
Author

ingablundell commented Jul 11, 2016

@jougs

Yes, and I have done so.

@jougs
Copy link
Contributor

jougs commented Jul 11, 2016

Looks good now. Many thanks! 👍 and merging.

@jougs jougs merged commit 47b52fe into nest:master Jul 11, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.