Rename Parameter class in Topology to TopologyParameter #408

Merged
merged 2 commits into from Jun 30, 2016

Conversation

Projects
None yet
2 participants
@heplesser
Contributor

heplesser commented Jun 24, 2016

The renaming is motivated by #352 and the need for a Parameter class in NEST. As an extra, it fixes a little detail in the scripts used to build the topology user manual. The main point of renaming in topology is that the Parameter class to be introduced in nestkernel will be the general parameter class for the future.

@jakobj @jougs Would you take a look---it is really just renaming.

@@ -24,6 +24,7 @@
import nest
import nest.topology as tp
import matplotlib.pyplot as plt
+from mpl_toolkits.mplot3d.axes3d import Axes3D

This comment has been minimized.

@jougs

jougs Jun 30, 2016

Contributor

Is this used somewhere in the file? If it is, why was this import not here before?

@jougs

jougs Jun 30, 2016

Contributor

Is this used somewhere in the file? If it is, why was this import not here before?

This comment has been minimized.

@heplesser

heplesser Jun 30, 2016

Contributor

This is required to enable 3d projection here. I am not sure why it was not needed before. That may be due to internal changes in matplotlib.

@heplesser

heplesser Jun 30, 2016

Contributor

This is required to enable 3d projection here. I am not sure why it was not needed before. That may be due to internal changes in matplotlib.

This comment has been minimized.

@jougs

jougs Jun 30, 2016

Contributor

Thanks for the explanation.

@jougs

jougs Jun 30, 2016

Contributor

Thanks for the explanation.

@jougs

This comment has been minimized.

Show comment
Hide comment
@jougs

jougs Jun 30, 2016

Contributor

Why did you re-add all the figures? For me they look the same, with only very minor shifts probably due to another version of some font library. Can you please remove them?

The code changes are trivial and look good to me. 👍 once the images are gone and my other comment is addressed.

Contributor

jougs commented Jun 30, 2016

Why did you re-add all the figures? For me they look the same, with only very minor shifts probably due to another version of some font library. Can you please remove them?

The code changes are trivial and look good to me. 👍 once the images are gone and my other comment is addressed.

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Jun 30, 2016

Contributor

@jougs I committed all the figure files because they were recreated with the modified script and topology code. Incidentally, this fixes #300: Fig 3.6. is now back in the PDF. But I agree that the figures should probably not be committed, just the final manuscript PDF. I will create a new issue for that change. I'd appreciate merging this PR soon, since #352 depends on it.

Contributor

heplesser commented Jun 30, 2016

@jougs I committed all the figure files because they were recreated with the modified script and topology code. Incidentally, this fixes #300: Fig 3.6. is now back in the PDF. But I agree that the figures should probably not be committed, just the final manuscript PDF. I will create a new issue for that change. I'd appreciate merging this PR soon, since #352 depends on it.

@jougs

This comment has been minimized.

Show comment
Hide comment
@jougs

jougs Jun 30, 2016

Contributor

Agreed. As this is just a simple rename otherwise, I'll merge without second review.

Contributor

jougs commented Jun 30, 2016

Agreed. As this is just a simple rename otherwise, I'll merge without second review.

@jougs jougs merged commit 8de7b59 into nest:master Jun 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@heplesser heplesser deleted the heplesser:rename_topo_param branch Aug 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment