Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of build jobs #409

Merged
merged 7 commits into from Jun 29, 2016
Merged

Reduce the number of build jobs #409

merged 7 commits into from Jun 29, 2016

Conversation

@jougs
Copy link
Contributor

jougs commented Jun 27, 2016

Many configuration options of NEST are actually independent. This means we don't have to run the full matrix, but just a minimal job, a maximal job, and some jobs for dependent options.

This PR simplifies the matrix from 8 runs to 4 runs while also adding a new option for builds with and without threading (04c668b).

Using this, I already found 3 tests that were failing when building without threading (5387bbc).

I suggest @heplesser and @lekshmideepu as reviewers.

jougs added 2 commits Jun 27, 2016
Many configuration options of NEST are actually independent.
This means we don't have to run the full matrix, but just a
minimal job, a maximal job, and some jobs for dependent options.

This commit simplifies the matrix from 8 runs to 4 runs while
also adding a new option for builds with and without threading.
@tammoippen
Copy link
Contributor

tammoippen commented Jun 28, 2016

Very nice work. How about having libltdl and readline also removed from the minimal configuration?

@lekshmideepu
Copy link
Contributor

lekshmideepu commented Jun 28, 2016

@jougs As we have discussed about this yesterday, I don't have any further comments from my side. It is great that you could find the 3 failing tests which depends on threading when the matrix job without threads were executed. In short, LGTM

@jougs
Copy link
Contributor Author

jougs commented Jun 29, 2016

@tammoippen: good idea, I've added these options in the latest commit.

@jougs
Copy link
Contributor Author

jougs commented Jun 29, 2016

Please don't merge yet! I'll push another commit soon!

…s instead of Jenkins
@jougs
Copy link
Contributor Author

jougs commented Jun 29, 2016

I've updated the documentation about continuous integration in the last commit. Please let me know if you require additional changes before merging. Many thanks!

## Build jobs

The CI system is set up to run upon commits to branches that are
related to a pull request, or for commits that are in a fork, for

This comment has been minimized.

Copy link
@heplesser

heplesser Jun 29, 2016

Contributor

Remove comma after "fork"

code is downloaded to an executor machine and the following actions
are performed:

- Install optional and mandatory packages that NEST can use

This comment has been minimized.

Copy link
@heplesser

heplesser Jun 29, 2016

Contributor

"can" -> "may"

@heplesser
Copy link
Contributor

heplesser commented Jun 29, 2016

👍 from me once the minor language issues are fixed.

@heplesser heplesser merged commit 758791c into nest:master Jun 29, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.