Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of params dictionary in Connect #441

Merged
merged 1 commit into from Aug 2, 2016

Conversation

@jakobj
Copy link
Contributor

jakobj commented Aug 1, 2016

If Connect was called with a parameter dictionary, this dictionary was ignored when connecting a normal node to a device or a device to a device. This is fixed here and a regression test is added. Thanks to @weidel-p for initial analysis of the bug. I suggest @weidel-p and @gtrensch as reviewers.
Fixes #437

If Connect was called with a parameter dictionary, this dictionary was
ignored when connecting a normal node to a device or a device to a
device. This is fixed here and a regression test is added.
@weidel-p
Copy link
Contributor

weidel-p commented Aug 2, 2016

The code and regressiontest looks nice and clean. Most important though, it solves the issue I had.

👍 from my side.

@gtrensch
Copy link
Collaborator

gtrensch commented Aug 2, 2016

I ran a couple tests with MUSIC version 1.1.15 using two channel connections (This is where @weidel-p went into that issue.). Everything works fine now. Also negative testing, particularly the regression test, behaves as expected.

👍 also from my side.

@abigailm abigailm merged commit 26ab3ac into nest:master Aug 2, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.