Fix handling of params dictionary in Connect #441

Merged
merged 1 commit into from Aug 2, 2016

Conversation

Projects
None yet
4 participants
@jakobj
Contributor

jakobj commented Aug 1, 2016

If Connect was called with a parameter dictionary, this dictionary was ignored when connecting a normal node to a device or a device to a device. This is fixed here and a regression test is added. Thanks to @weidel-p for initial analysis of the bug. I suggest @weidel-p and @gtrensch as reviewers.
Fixes #437

Fix handling of params dictionary in Connect
If Connect was called with a parameter dictionary, this dictionary was
ignored when connecting a normal node to a device or a device to a
device. This is fixed here and a regression test is added.
@weidel-p

This comment has been minimized.

Show comment
Hide comment
@weidel-p

weidel-p Aug 2, 2016

Contributor

The code and regressiontest looks nice and clean. Most important though, it solves the issue I had.

👍 from my side.

Contributor

weidel-p commented Aug 2, 2016

The code and regressiontest looks nice and clean. Most important though, it solves the issue I had.

👍 from my side.

@gtrensch

This comment has been minimized.

Show comment
Hide comment
@gtrensch

gtrensch Aug 2, 2016

Contributor

I ran a couple tests with MUSIC version 1.1.15 using two channel connections (This is where @weidel-p went into that issue.). Everything works fine now. Also negative testing, particularly the regression test, behaves as expected.

👍 also from my side.

Contributor

gtrensch commented Aug 2, 2016

I ran a couple tests with MUSIC version 1.1.15 using two channel connections (This is where @weidel-p went into that issue.). Everything works fine now. Also negative testing, particularly the regression test, behaves as expected.

👍 also from my side.

@abigailm abigailm merged commit 26ab3ac into nest:master Aug 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment