New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve numerical stability of some tests. #466

Merged
merged 1 commit into from Oct 6, 2016

Conversation

Projects
None yet
3 participants
@heplesser
Contributor

heplesser commented Aug 18, 2016

Revised tsodyks-test to use explicitly defined input spike trains instead of trains generated by a DC-driven neuron. This avoids numerical instabilities.

Revised tsodyks-test to use explicitly defined input spike trains ins…
…tead of trains generated by a DC-driven neuron. This avoids numerical instabilities.
@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Aug 18, 2016

Contributor

I suggest @jougs and @terhorstd as reviewers.

Contributor

heplesser commented Aug 18, 2016

I suggest @jougs and @terhorstd as reviewers.

@DimitriPlotnikov

This comment has been minimized.

Show comment
Hide comment
@DimitriPlotnikov

DimitriPlotnikov Oct 4, 2016

Improves readability of the test and makes it more numerically stable.

Improves readability of the test and makes it more numerically stable.

@Silmathoron

Update is clear, it uses same spike times as the previously existing neuron and produces the expected result.

@heplesser heplesser merged commit 9e31338 into nest:master Oct 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@heplesser heplesser deleted the heplesser:stable_tsodyks_tests branch Mar 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment