New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new flag 'supports_precise_spikes' #475

Merged
merged 6 commits into from Sep 27, 2016

Conversation

Projects
None yet
4 participants
@DimitriPlotnikov

Introduce new flag 'support_precise_spikes' for nodes which support off_grid events

@DimitriPlotnikov DimitriPlotnikov changed the title from Introduce new flag 'support_precise_spikes' to Introduce new flag 'supports_precise_spikes' Sep 9, 2016

Show outdated Hide outdated nestkernel/nest_names.h
extern const Name synapse_label; //!< Label id of synapses with labels
extern const Name synapse_model; //!< Connection parameters
extern const Name synapse_modelid; //!< Connection parameters
extern const Name supports_precise_spikes; //!< true iff. suports precise

This comment has been minimized.

@heplesser

heplesser Sep 9, 2016

Contributor

"if model supports"

@heplesser

heplesser Sep 9, 2016

Contributor

"if model supports"

Show outdated Hide outdated testsuite/unittests/test_supports_precise_spikes_flag.sli
(unittest) run
/unittest using
{ /hh_psc_alpha GetDefaults /supports_precise_spikes get not } assert_or_die

This comment has been minimized.

@heplesser

heplesser Sep 9, 2016

Contributor

I would add at least one test with a precise neuron as well to check that it returns true.

@heplesser

heplesser Sep 9, 2016

Contributor

I would add at least one test with a precise neuron as well to check that it returns true.

This comment has been minimized.

@DimitriPlotnikov

DimitriPlotnikov Sep 9, 2016

Yes, of course. As you can see, I add stuff it inclemently. Last time, I had a problem that NEST build worked locally, but CI refused it. So, now I'm trying to find the first instruction that breaks the build. Of course, in the next step I' ll add: { /parrot_neuron_ps GetDefaults /supports_precise_spikes get } assert_or_die iff. the current build succeeds.

@DimitriPlotnikov

DimitriPlotnikov Sep 9, 2016

Yes, of course. As you can see, I add stuff it inclemently. Last time, I had a problem that NEST build worked locally, but CI refused it. So, now I'm trying to find the first instruction that breaks the build. Of course, in the next step I' ll add: { /parrot_neuron_ps GetDefaults /supports_precise_spikes get } assert_or_die iff. the current build succeeds.

@jougs

This comment has been minimized.

Show comment
Hide comment
@jougs

jougs Sep 9, 2016

Contributor

@DimitriPlotnikov: you can enable Travis CI for your own repositories here. This way you can test things in your branches before starting a pull request and flooding all of NEST Initiative with each change. This should minimize the risk that things work locally and fail on Travis.

Contributor

jougs commented Sep 9, 2016

@DimitriPlotnikov: you can enable Travis CI for your own repositories here. This way you can test things in your branches before starting a pull request and flooding all of NEST Initiative with each change. This should minimize the risk that things work locally and fail on Travis.

@DimitriPlotnikov

This comment has been minimized.

Show comment
Hide comment
@DimitriPlotnikov

DimitriPlotnikov Sep 9, 2016

@jougs It is really great!

@jougs It is really great!

@apeyser

Looks good to me 👍

@heplesser

Looks good to me, too, now.

@heplesser heplesser merged commit 4b9dcc2 into nest:master Sep 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment