Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Revise implementation of ht_neuron #491
Ok, the changes make sense for me, I'll try to test the model at some point this week.
There are a few points that need discussing, though.
@Silmathoron I now noticed that the model needs a bit more work. I will change all names to use
But I probably won't get that done today.
The documentation of the NMDA current is very clear and helpful! Although I would add an explicit definition of g (what is g_NMDA in the paper). The calculation of the NMDA part of I_syn and propagation of Mg_fast and Mg_slow look correct to me! I approve this pull request.
Here is a first round of comments, I'll try to check the equations and test the model next week:
ht_connection.h, line 44, it should be
tau_rec, if possible, cf. comments below).
THIS MODEL NEURON HAS NOT BEEN TESTED EXTENSIVELY!comment leaves me perplex... what do you mean exactly? Wouldn't a test file solve the problem?
Ok, almost everything looks good to me except some lingering
t_spikes that need to disappear and a few remarks on the notebook.
Thanks a lot for the impressive restructuring, the code looks much clearer now, and the notebook really makes it a lot easier to understand too!
If you can just add axis names to the existent (and future) figures, it will be perfect ;)
Great work on that, the update function is much clearer now!
There are only a few points left that need some clarifications; also I realized that I forgot to ask, but I find it very surprising that, in such a detailed model, conductances cannot be taken directly from biological data... could you at least provide typical values that would allow for an approximate conversion?
I have just pushed a new version addressing @Silmathoron's comments and also
I really like the notebook! I approve this pull request!