Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct record for psc in iaf_psc_alpha #500

Merged
merged 2 commits into from Oct 4, 2016

Conversation

@Silmathoron
Copy link
Member

Silmathoron commented Sep 29, 2016

This PR addresses issue #499
I replaced the yX_in/ex_ by the corresponding names dI_ex/in_ and I_ex/in_ for clarity in State_.

Copy link
Contributor

heplesser left a comment

@Silmathoron Thanks for spotting and fixing this and cleaning up the code as well! After a quick search it seems no other model has this problem.

@heplesser
Copy link
Contributor

heplesser commented Sep 29, 2016

@jougs Could you give it a quick check?

@jougs
jougs approved these changes Oct 4, 2016
Copy link
Contributor

jougs left a comment

Looks good to me! Thanks for your contribution!

@jougs jougs merged commit f01fe0e into nest:master Oct 4, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@flinz
Copy link
Contributor

flinz commented Oct 5, 2016

PR #500 is merged? I guess congrats are in order: To 500 more!

@heplesser
Copy link
Contributor

heplesser commented Oct 5, 2016

@flinz It is a bit of a cheat: Github enumerates issues and PRs in one series, so at present, we only have 234 merged PRs.

@Silmathoron Silmathoron deleted the Silmathoron:iaf_psc_alpha_correct_record branch Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.