Correct record for psc in iaf_psc_alpha #500

Merged
merged 2 commits into from Oct 4, 2016

Conversation

Projects
None yet
4 participants
@Silmathoron
Contributor

Silmathoron commented Sep 29, 2016

This PR addresses issue #499
I replaced the yX_in/ex_ by the corresponding names dI_ex/in_ and I_ex/in_ for clarity in State_.

@heplesser

@Silmathoron Thanks for spotting and fixing this and cleaning up the code as well! After a quick search it seems no other model has this problem.

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Sep 29, 2016

Contributor

@jougs Could you give it a quick check?

Contributor

heplesser commented Sep 29, 2016

@jougs Could you give it a quick check?

@jougs

jougs approved these changes Oct 4, 2016

Looks good to me! Thanks for your contribution!

@jougs jougs merged commit f01fe0e into nest:master Oct 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@flinz

This comment has been minimized.

Show comment
Hide comment
@flinz

flinz Oct 5, 2016

Contributor

PR #500 is merged? I guess congrats are in order: To 500 more!

Contributor

flinz commented Oct 5, 2016

PR #500 is merged? I guess congrats are in order: To 500 more!

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Oct 5, 2016

Contributor

@flinz It is a bit of a cheat: Github enumerates issues and PRs in one series, so at present, we only have 234 merged PRs.

Contributor

heplesser commented Oct 5, 2016

@flinz It is a bit of a cheat: Github enumerates issues and PRs in one series, so at present, we only have 234 merged PRs.

@Silmathoron Silmathoron deleted the Silmathoron:iaf_psc_alpha_correct_record branch Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment