New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct input handling for aeif_cond_beta_multisynapse #510 and Update aeif_cond_beta_multisynapse to new aeif numerics approach #514 #516

Merged
merged 25 commits into from Oct 26, 2016
Commits
Jump to file or symbol
Failed to load files and symbols.
+1 −1
Diff settings

Always

Just for now

Viewing a subset of changes. View all

minor fixes to formatting

  • Loading branch information...
golosio committed Oct 15, 2016
commit 05eef9ae2f5214a7ea3dda967578aba7c03c0e67
@@ -675,7 +675,7 @@ aeif_cond_beta_multisynapse_dynamics( double,
const double I_spike = node.P_.Delta_T == 0. ? 0 : node.P_.Delta_T

This comment has been minimized.

@Silmathoron

Silmathoron Oct 17, 2016

Contributor

To be consistent (and homogeneous), change to node.P_.Delta_T * node.P_.g_L * std::exp( ( V - node.P_.V_th ) / node.P_.Delta_T )

@Silmathoron

Silmathoron Oct 17, 2016

Contributor

To be consistent (and homogeneous), change to node.P_.Delta_T * node.P_.g_L * std::exp( ( V - node.P_.V_th ) / node.P_.Delta_T )

This comment has been minimized.

@golosio

golosio Oct 18, 2016

Contributor

As a physicist I like when variables have a name appropriate for what they represent and consistent with their units!

@golosio

golosio Oct 18, 2016

Contributor

As a physicist I like when variables have a name appropriate for what they represent and consistent with their units!

This comment has been minimized.

@heplesser

heplesser Oct 24, 2016

Contributor

I think for clarity, it would be good to place everything after the : in parentheses, even if not strictly necessary.

@heplesser

heplesser Oct 24, 2016

Contributor

I think for clarity, it would be good to place everything after the : in parentheses, even if not strictly necessary.

* std::exp( ( V - node.P_.V_th ) / node.P_.Delta_T );
// dv/dt
f[ S::V_M ] = ( -node.P_.g_L * ( V - node.P_.E_L - I_spike ) + I_syn - w

This comment has been minimized.

@Silmathoron

Silmathoron Oct 17, 2016

Contributor

Switch to ( -node.P_.g_L * ( V - node.P_.E_L ) + I_spike + I_syn + ...

@Silmathoron

Silmathoron Oct 17, 2016

Contributor

Switch to ( -node.P_.g_L * ( V - node.P_.E_L ) + I_spike + I_syn + ...

This comment has been minimized.

@golosio

golosio Oct 18, 2016

Contributor

done

@golosio

golosio Oct 18, 2016

Contributor

done

+ node.P_.I_e + node.B_.I_stim_ ) / node.P_.C_m;
ProTip! Use n and p to navigate between commits in a pull request.