Use NEST variable (in ms) for printing acc. latency #535

Merged
merged 3 commits into from Nov 2, 2016

Conversation

Projects
None yet
4 participants
@mdjurfeldt
Contributor

mdjurfeldt commented Nov 1, 2016

No description provided.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Nov 1, 2016

@mdjurfeldt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tammoippen, @otizonaizit and @heplesser to be potential reviewers.

@mdjurfeldt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tammoippen, @otizonaizit and @heplesser to be potential reviewers.

@heplesser

@mdjurfeldt I think it would be a good idea to label the local variable with the unit, e.g.,

const double acceptable_latency_s = 0.001 * acceptable_latency_;

to make things a little clearer for the reader.

@mdjurfeldt

This comment has been minimized.

Show comment
Hide comment
@mdjurfeldt

mdjurfeldt Nov 1, 2016

Contributor

Requested changes committed.

Contributor

mdjurfeldt commented Nov 1, 2016

Requested changes committed.

@jougs

jougs approved these changes Nov 2, 2016

Thanks for finding and fixing this.

@jougs jougs merged commit 1fd378f into nest:master Nov 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment