Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NEST variable (in ms) for printing acc. latency #535

Merged
merged 3 commits into from Nov 2, 2016

Conversation

@mdjurfeldt
Copy link
Contributor

@mdjurfeldt mdjurfeldt commented Nov 1, 2016

No description provided.

@mention-bot
Copy link

@mention-bot mention-bot commented Nov 1, 2016

@mdjurfeldt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tammoippen, @otizonaizit and @heplesser to be potential reviewers.

Copy link
Contributor

@heplesser heplesser left a comment

@mdjurfeldt I think it would be a good idea to label the local variable with the unit, e.g.,

const double acceptable_latency_s = 0.001 * acceptable_latency_;

to make things a little clearer for the reader.

@mdjurfeldt
Copy link
Contributor Author

@mdjurfeldt mdjurfeldt commented Nov 1, 2016

Requested changes committed.

@jougs
jougs approved these changes Nov 2, 2016
Copy link
Contributor

@jougs jougs left a comment

Thanks for finding and fixing this.

@jougs jougs merged commit 1fd378f into nest:master Nov 2, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.