Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion from heterogeneous to homogeneous connector when deleting last synapse of a type #566

Merged
merged 1 commit into from Dec 12, 2016

Conversation

@jakobj
Copy link
Contributor

@jakobj jakobj commented Nov 25, 2016

See #565 for a discussion of the issue. This PR fixes that issue and provides a test.
I suggest @sdiazpier and @suku248 as reviewers.

@jakobj jakobj force-pushed the jakobj:fix565_sp_disables_connectors branch from b74aff5 to 5eb1b47 Nov 25, 2016
Copy link

@janhahne janhahne left a comment

I agree with your analysis in issue #565 and this PR is a good solution to the problem. I only have a couple of minor comments regarding the new unit test. Once they are addressed I am happy 👍

Thanks a lot for fixing that!

Synopsis: (issue-565) run -> NEST exits if test fails

Description:
This test provokes a switch from a heterogeneous connector to a homogeneous connector using the structural plasticity framework and asserts that the resulting homogeneous connector is correctly used.

This comment has been minimized.

@janhahne

janhahne Dec 1, 2016

This line could use a line break


% Delete the first connection again, causing the heterogeneous
% connector to be turned into a homogeneous connector
[2] cvgidcollection [1] cvgidcollection << /rule /all_to_all >> << /model /static_synapse >> Disconnect_g_g_D_D

This comment has been minimized.

@janhahne

janhahne Dec 1, 2016

Same here, maybe add a line break after /all_to_all >>

% The spike detector should have recorded three events
{
3 GetStatus /n_events get 3 eq
} assert_or_die

This comment has been minimized.

@janhahne

janhahne Dec 1, 2016

I see from your example in the issue #565 how this ensures that everything works properly, but wouldn't it be much more fail-safe to add another simulation to this unit test where one neuron with the same parameters is just connected to the spike detector (without disconnecting a temporary connection) and then (after both simulations) to compare the actual spike times recorded by the spike detector?

M_ERROR setverbosity

% Create neurons and spike detector
/iaf_neuron 2 << /I_e 400. >> Create /neurons Set

This comment has been minimized.

@janhahne

janhahne Dec 1, 2016

Use iaf_psc_alpha instead (see PR #526)

last synapse of a type
@jakobj jakobj force-pushed the jakobj:fix565_sp_disables_connectors branch from 5eb1b47 to 1915f1c Dec 11, 2016
@jakobj
Copy link
Contributor Author

@jakobj jakobj commented Dec 11, 2016

Thanks @janhahne for the quick review. I have pushed a new version addressing all your comments.

@sdiazpier
Copy link
Contributor

@sdiazpier sdiazpier commented Dec 11, 2016

Dear @jakobj thanks for fixing this issue. I agree with the solution 👍 from my side.

@heplesser
Copy link
Contributor

@heplesser heplesser commented Dec 12, 2016

@janhahne Could you confirm that @jakobj has addressed your concerns successfully?

@janhahne
Copy link

@janhahne janhahne commented Dec 12, 2016

@heplesser @jakobj Yes, he did! Nice work 👍

@heplesser heplesser merged commit d87a66a into nest:master Dec 12, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.