Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Deprecation warnings for features that will disappear (fixes #552) #580
Added deprecation warnings for features that will disappear in NEST 3, which includes all subnet functions, the
The PR also includes partial work on #558, by making sure the examples do not display introduced deprecation warnings.
I have a very general remark: shouldn't deprecation warnings be handled on the SLI level wherever possible? This way they'd automatically bubble up to PyNEST and would only have to be implemented once.
For models, we could for example add two flags in the
@jougs We have now added support for deprecation at the C++ level. I am wondering what to do about the SLI examples. We would have to write quite a bit of code programming around the lack of full support for GIDCollections, which will simplify significantly again in NEST 3. Therefore, I wonder if it isn't better to leave the SLI examples as they are, even though the user then will see some warnings. The problem does not (or to a much lesser degree) exist at the PyNEST level, since lists of GIDs there behave almost like GIDCollections will in NEST 3.
referenced this pull request
Dec 15, 2016
Looks quite good, just a few language fixes needed.
Very nice work indeed. Many thanks for considering my concerns and making these extensive changes. I'll approve once my minor comments are addressed.
@heplesser: I agree regarding the SLI examples. We can't possibly re-formulate all of them now and they will be naturally adapted when the deprecated models/functions are removed. I'm happy to accept this PR with the current current scope once my comments are addressed.