GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This PR fixes an incompatibility with the K compiler as discussed in #581.
I suggest @janhahne and @JanneM as reviewers.
The static is confusing here, since this use of static is so rare hardly anyone knows what it does. It does make sense, as it makes sure there won't be any conflicts with functions of same name and signature defined in other cpp-files, but you should probably comment on this here.
I am also wondering a little about the name. Maybe extend( connectome, conns_in_thread ) or add_to( connectome, conns_in_thread ) would make for even more readable code.
extend( connectome, conns_in_thread )
add_to( connectome, conns_in_thread )
I don't have enough experience with the code base to review the patch, I think. But I agree that the name should reflect what the code does to nest rather than what it does to the data structure.
The original code uses static, so it makes sense to keep it for this patch. If it's unneeded, then it's probably better to create a separate issue to change that.
I agree with Janne on the second part. Regarding the name I don't have a strong opinion, I would be fine with extend or even something more specific extend_connectome that actually describes would be would like to achieve here.
extend_connectome() should be fine.
Nice fix! I assume that you compiled it on K and can confirm that it works there (because I didn't)?
Once there is an agreement on the name of the function, I am 👍 for merging
Thanks @janhahne. Yes I compiled it on K (it works) and will do so again, before merging, after we have settled on a name.
Replace operator<< with regular function to avoid issues with K compiler
Renamed and made sure that it compiles on K. A second thumbs up anyone?
👍 and merging.