Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in sp disconnect that could lead to heterogeneous connectors not being used any more during spike delivery #597

Merged
merged 1 commit into from Dec 22, 2016

Conversation

@jakobj
Copy link
Contributor

jakobj commented Dec 17, 2016

This fixes #596 and adds a regressiontest.
I would suggest @sdiazpier @suku or @janhahne as reviewers.

being used any more during spike delivery
@jakobj jakobj force-pushed the jakobj:fix596_sp_disables_het_connectors branch from 65f61aa to 8fc57f1 Dec 17, 2016
@heplesser heplesser requested review from sdiazpier and janhahne Dec 18, 2016
@terhorstd terhorstd added this to the NEST 2.12 milestone Dec 19, 2016
Copy link

janhahne left a comment

I agree with the error analysis in the issue and with the fix in this PR. Nice work!

@sdiazpier
Copy link
Contributor

sdiazpier commented Dec 21, 2016

Thanks for fixing this issue @jakobj. 👍 from my side.

@heplesser
Copy link
Contributor

heplesser commented Dec 21, 2016

@sdiazpier Could you explicitly approve the PR in Github. One way to do so is to go to the "Files changed" tab, click on the green "Review changes" button in the top-right corner and select "Approve".

Copy link
Contributor

sdiazpier left a comment

I agree with the changes.

@heplesser heplesser merged commit 90e362a into nest:master Dec 22, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.