Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new matrix jobs. #640

Merged
merged 5 commits into from Jan 28, 2017
Merged

Added new matrix jobs. #640

merged 5 commits into from Jan 28, 2017

Conversation

@lekshmideepu
Copy link
Contributor

lekshmideepu commented Jan 25, 2017

This will catch errors like the ones in #638

@lekshmideepu
Copy link
Contributor Author

lekshmideepu commented Jan 25, 2017

I suggest @jougs and @heplesser as the reviewers

@lekshmideepu
Copy link
Contributor Author

lekshmideepu commented Jan 25, 2017

This particular job will fail on Travis now and @sdiazpier has to fix the tests

Copy link
Contributor

heplesser left a comment

Looks good to me.

@lekshmideepu
Copy link
Contributor Author

lekshmideepu commented Jan 26, 2017

It fails again as threading was not enabled in the new matrix job.

Weight Recorder rports ... SKIP: GSL is not available
Weight Recorder Single Threaded ... ok
FAIL: test_enable_multithread (nest.tests.test_sp.test_enable_multithread.TestEnableMultithread)
AssertionError: NESTError not raised
FAIL: test_multithread_enable (nest.tests.test_sp.test_enable_multithread.TestEnableMultithread)
AssertionError: NESTError not raised
FAIL: test_gaussian_growth_curve (nest.tests.test_sp.test_growth_curves.TestGrowthCurve)
raise AssertionError(msg)
AssertionError:
FAIL: test_linear_growth_curve (nest.tests.test_sp.test_growth_curves.TestGrowthCurve)
raise AssertionError(msg)
AssertionError:
FAILED (SKIP=24, failures=4)

@lekshmideepu
Copy link
Contributor Author

lekshmideepu commented Jan 26, 2017

Will add another two job combinations in the matrix job:
Python: ON, Threading: ON, MPI:OFF
Python: ON, Threading: OFF, MPI:ON

@lekshmideepu lekshmideepu changed the title Added a new Python only matrix job Added new matrix jobs Jan 26, 2017
@lekshmideepu lekshmideepu changed the title Added new matrix jobs Added new matrix jobs as some tests are failing in Travis Jan 26, 2017
@lekshmideepu lekshmideepu changed the title Added new matrix jobs as some tests are failing in Travis Added new matrix jobs. Jan 26, 2017
@lekshmideepu
Copy link
Contributor Author

lekshmideepu commented Jan 26, 2017

#642 would solve the issue with failing tests

@heplesser heplesser added this to the NEST 2.12 milestone Jan 26, 2017
@lekshmideepu
Copy link
Contributor Author

lekshmideepu commented Jan 27, 2017

@jougs and @heplesser Since #642 is merged, Travis builds are fine for this PR.

@jougs
jougs approved these changes Jan 28, 2017
Copy link
Contributor

jougs left a comment

Thanks for spotting and fixing this.

@jougs jougs merged commit e813ef3 into nest:master Jan 28, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.