GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This PR solves a problem with two python tests which require threading but were not being skipped if threading was not enabled.
Added check on threading in two python tests which require this to run.
Looks good to me
@sdiazpier Fine in principle, but one can do the SLI-interface more elegantly.
It would be even better to do as follows:
HAVE_OPENMP = nest.sli_func("is_threaded")
This insulates the details of how threading is marked at the sli level. The result is a bool.
With the change above, this would simplify to
@unittest.skipIf(HAVE_OPENMP, 'OpenMP is not available')
Changed the way the check for multi threading is made in tests
Dear @heplesser thanks for the suggestion. I have made the changes. Please let me know if anything else is missing.
Summary: Suppresses thread-dependent threads if NEST was build without threads.