Join GitHub today
split simulate into prepare, run and finalize #650
Needs careful check on simulation_manager, given that it's a conflict bottleneck on master.
As requested by several projects including visualization, this PR makes it possible to split a run into multiple time chunks, without doing the calibration and teardown steps for every run.
A follow-up issue would be to make a run interruptible, returning the time actually run so that the simulation can be continued with another run call.
Split into run: passes installcheck pull time out of prepare prepare_simulation_ code into prepare prepare_simulation_.2 code into prepare prepare_simulation_.3 code into prepare prepare_simulation_.4 code into prepare prepare_simulation_.all code into prepare Map Run to Function Run breakup doesnt break Simulate tests Add python bindings Seems to run a tester Add contextmanager IterateRuns Split run passes test test-split fix copyright Format with clang Lost manager
heplesser left a comment
@apeyser This is just a first review, I have not evaluated the changes to simulate in detail. Could you explain the rationale for this PR? That would make it easier to understand and evaluate. I also wonder what would happen if one called