New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quantal stdp test for numpy #681

Merged
merged 2 commits into from Mar 30, 2017

Conversation

Projects
None yet
3 participants
@mschmidt87

mschmidt87 commented Mar 15, 2017

This pull request addresses #680 and contains the following changes:

  • Convert the float variables in the test to integers when they are used as indices to numpy arrays. I decided to do this rather then defining them as integers in the first place because a) defining times as floats seems plausible to me and b) the conversion of t_tot had been implemented in this test at a different location earlier.
  • Remove two parameter dictionaries that were not used in the script.
  • Make travis download the latest release of numpy via pip.
@heplesser

@mschmidt87 Please do not change the travis.yml file in this PR. I will comment on this in the issue, but it is a separate issue and requires careful consideration. I also added some small suggestions to the test.

Maximilian Schmidt added some commits Mar 15, 2017

Maximilian Schmidt
Fix quantal_stdp_test to make it run with numpy 1.12.0
Convert float variables to integers when using them as indices to numpy arrays and make reshaping of voltmeter more general
@mschmidt87

This comment has been minimized.

Show comment
Hide comment
@mschmidt87

mschmidt87 Mar 16, 2017

Thank you for your feedback. I removed the commit touching .travis.yml from the PR and addressed your comments. I furthermore removed t_plot from the script because it was only used for computing the error and I didn't see a reason to not take the entire dataset into account here.

mschmidt87 commented Mar 16, 2017

Thank you for your feedback. I removed the commit touching .travis.yml from the PR and addressed your comments. I furthermore removed t_plot from the script because it was only used for computing the error and I didn't see a reason to not take the entire dataset into account here.

@hakonsbm

Looks good to me.

@heplesser heplesser merged commit ad93653 into nest:master Mar 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment