Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to issue #683. #686

Merged
merged 5 commits into from Mar 27, 2017
Merged

Fix to issue #683. #686

merged 5 commits into from Mar 27, 2017

Conversation

@kappeld
Copy link
Contributor

@kappeld kappeld commented Mar 21, 2017

  • A second template argument to member function register_connection_model of the ModelManager has been added, which allows the user to specify the type of connector model.
  • An overloaded function to register_connection_model has been added that uses the default connector model GenericConnectorModel.
Kappel David added 4 commits Mar 20, 2017
Kappel David Kappel David
- A second template argument to member function register_connection_model of the ModelManager has been added, which allows the user to specify the type of connector model.
- An overloaded function to register_connection_model has been added that uses the default connector model GenericConnectorModel.
Kappel David Kappel David
Kappel David Kappel David
Copy link
Contributor

@heplesser heplesser left a comment

Looks fine to me except for a typo and one suggestion.

*/
template < class ConnectionT >
void register_connection_model( const std::string& name,
bool requires_symmetric = false );

/**
* Register a synape model with a costom Connector model and without any

This comment has been minimized.

@heplesser

heplesser Mar 24, 2017
Contributor

costom -> custom

*/
template < class ConnectionT, template < class > class ConnectorModelT >
void register_connection_model( const std::string& name,
bool requires_symmetric = false );

This comment has been minimized.

@heplesser

heplesser Mar 24, 2017
Contributor

For new code, please use typename instead of class for the template argument type; maybe fix that in the old version of the function as well.

…e typename, fixed typo in doc
@kappeld
Copy link
Contributor Author

@kappeld kappeld commented Mar 26, 2017

I also changed the template argument type of register_secondary_connection_model to typename such that ConnectionT is consistently used with the same type in all methods. typename is not allowed in the context of ConnectorModelT. Here we have to use "class".

Copy link
Contributor

@weidel-p weidel-p left a comment

@kappeld everything looks fine to me, too. Thank you.

@heplesser heplesser merged commit 58fd190 into nest:master Mar 27, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@heplesser
Copy link
Contributor

@heplesser heplesser commented Mar 27, 2017

  • Extend internal API to allow registration of ConnectorModels not based on GenericConnectorModel.
  • Fixes #683.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.