New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to issue #683. #686

Merged
merged 5 commits into from Mar 27, 2017

Conversation

Projects
None yet
3 participants
@kappeld
Contributor

kappeld commented Mar 21, 2017

  • A second template argument to member function register_connection_model of the ModelManager has been added, which allows the user to specify the type of connector model.
  • An overloaded function to register_connection_model has been added that uses the default connector model GenericConnectorModel.

Kappel David added some commits Mar 20, 2017

Kappel David Kappel David
Fix to issue #683.
- A second template argument to member function register_connection_model of the ModelManager has been added, which allows the user to specify the type of connector model.
- An overloaded function to register_connection_model has been added that uses the default connector model GenericConnectorModel.
@heplesser

Looks fine to me except for a typo and one suggestion.

Show outdated Hide outdated nestkernel/model_manager.h
Show outdated Hide outdated nestkernel/model_manager.h
@kappeld

This comment has been minimized.

Show comment
Hide comment
@kappeld

kappeld Mar 26, 2017

Contributor

I also changed the template argument type of register_secondary_connection_model to typename such that ConnectionT is consistently used with the same type in all methods. typename is not allowed in the context of ConnectorModelT. Here we have to use "class".

Contributor

kappeld commented Mar 26, 2017

I also changed the template argument type of register_secondary_connection_model to typename such that ConnectionT is consistently used with the same type in all methods. typename is not allowed in the context of ConnectorModelT. Here we have to use "class".

@weidel-p

@kappeld everything looks fine to me, too. Thank you.

@heplesser heplesser merged commit 58fd190 into nest:master Mar 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Mar 27, 2017

Contributor
  • Extend internal API to allow registration of ConnectorModels not based on GenericConnectorModel.
  • Fixes #683.
Contributor

heplesser commented Mar 27, 2017

  • Extend internal API to allow registration of ConnectorModels not based on GenericConnectorModel.
  • Fixes #683.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment