Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Throw exception when connecting fails #693
This PR fixes an issue where in some cases an attempt to create a connection fails silently, such as when trying to connect a multimeter to a generator. NEST will now throw an exception in these cases.
Additionally, a part of the regressiontest issue-211 that now throws an exception has been removed, and tests to make sure that NEST throws an exception to avoid silent failure has been added.
This fixes #578.
Travis currently fails due to formatting problems. I would suggest to wait until #691 is merged to master, merge that then from master into this branch.
These are reasonably changes, however I think one return was missed and the tests need to be adapted. ps: sorry for taking so long to review.
@jakobj Thank you for you review. Besides reinstating the missing test in issue-211 and adding a