Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate constructors for long & double from Time units #699

Merged
merged 2 commits into from Apr 5, 2017

Conversation

@apeyser
Copy link
Contributor

@apeyser apeyser commented Apr 4, 2017

Redundant constructors for both long & double types, which can only cause ambiguities since a long with a C++03 constructor is coerced automagically.
See #669 for example.

@apeyser apeyser requested review from heplesser and gtrensch Apr 4, 2017
Copy link
Contributor

@heplesser heplesser left a comment

Looks fine to me, I do not quite understand why we ever added the long variants. I approve, conditional to all tests passing.

Copy link
Collaborator

@gtrensch gtrensch left a comment

Approved!

@heplesser heplesser modified the milestone: NEST 3.0 Apr 5, 2017
@heplesser heplesser merged commit baad007 into nest:master Apr 5, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.