New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite::issue-521 - *_hpc connections return local id instead of g… #714

Merged
merged 27 commits into from Jun 21, 2017

Conversation

Projects
None yet
4 participants
@tillschumann
Contributor

tillschumann commented Apr 24, 2017

#521
testsuite::issue-521 - *_hpc connections return local id instead of global id of target neuron

*_hpc connections should only return thread_local_target instead of target
to avoid confusion

Currently, it is not possible to get the target gid from a *_hpc connection.
To get it, we would need to pass the thread-id to the get_status function as an argument.
I think it is easier to leave out "target" as an return entry and return "thread_local_target" instead to avoid confusion.

@heplesser

This looks quite fine, just a few small things to fix.

Show outdated Hide outdated nestkernel/nest_names.cpp
Show outdated Hide outdated nestkernel/nest_names.h
Show outdated Hide outdated testsuite/regressiontests/issue-521.sli
Show outdated Hide outdated testsuite/regressiontests/issue-521.sli
@suku248

I understand that it would be quite inconvenient to change the signature of set_status. However, I am not quite happy with the solution here. It would be more consistent to provide the target gid also for *_hpc synapses. Please have a look at this code.

@heplesser

@tillschumann Just two little things left from my side; a recent improvement in unittest requires a small adaptation.

Show outdated Hide outdated testsuite/regressiontests/issue-521.sli
Show outdated Hide outdated testsuite/regressiontests/issue-521.sli
@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Jun 1, 2017

Contributor

@kappeld This bug fix PR changes the signature of ConnectorBase::get_synapse_status(). Could you check if that will cause problems for your module and report back here?

Contributor

heplesser commented Jun 1, 2017

@kappeld This bug fix PR changes the signature of ConnectorBase::get_synapse_status(). Could you check if that will cause problems for your module and report back here?

@kappeld

Tests passed! No conflicts from our side!

@suku248

👍

Update issue-521.sli
Updated test description to the actual solution of this issue.
@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Jun 21, 2017

Contributor

Release nodes: GetConnections work correctly now also for _hpc synapses.

Contributor

heplesser commented Jun 21, 2017

Release nodes: GetConnections work correctly now also for _hpc synapses.

@heplesser heplesser merged commit f201ca0 into nest:master Jun 21, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment