Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Ensure Name insertion is done in thread-serial context and replace strings with Name objects #724
This looks very fine, just some minor points on alphabetical order. A proper regression test for this issue would be difficult to create, since the
Name table is created only once per nest invocation and not reset by
ResetKernel. Since we are playing it safe now with the assertion in
Name::insert() and had some other tests that triggered when the
Name table got corrupted, I think we can proceed without an explicit unit test here.