Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circumvent negative max_width in Travis log parser #731

Merged
merged 1 commit into from May 23, 2017

Conversation

@gtrensch
Copy link
Collaborator

@gtrensch gtrensch commented May 22, 2017

Bypass Travis issue: ValueError: invalid width -29 (must be > 0)

On Travis column_max_width sometimes returns a negative value causing the parser script to abend. The calculation is based on the terminal width which seems to be zero in that case. This pull requests adds two lines to set the value to 70 if it is negative.

@heplesser heplesser self-requested a review May 22, 2017
Copy link
Contributor

@heplesser heplesser left a comment

Approved conditional on Travis passing.

@heplesser
Copy link
Contributor

@heplesser heplesser commented May 23, 2017

Since this is a trivial but urgent fix to our build system, I merge based on a single review.

@heplesser heplesser merged commit 7509934 into nest:master May 23, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.