Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix possible deadlock in neuron update loop in multithreaded code (fixes #718) #734
This PR fixes a potential deadlock when a neuron throws an exception during multithreaded simulation (#718).
Since it is difficult to test for deadlocks in unittests, there is no automated test. This manual test is inspired by @maharjun's deadlock module. To test, add the following to the beginning of
if ( this->get_thread() == 2 ) throw KernelException("Thread 2");
and run the following SLI script from a file
NEST should hang if you use current master; with the correction given here, NEST should terminate with an error message.
@maharjun Would you test and review this fix?