Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Add tests for synapse parameter check (fixes #735) #736
This PR removes some code from
I added regression test to ensure that attempts to set model-only parameters on individual synapses raise errors.
TBH I'm not really familiar with the way the connection builders work, the issue #735 was onlly noticed by me when I was inspecting the diffs, and this does indeed remove the offending piece of code. Regarding actual function, it would be better if someone else were to review that.
I am a bit confused about what the removed test is supposed to do. I don't see the connection between
Also, when testing with master on my computer, I get the "unused parameter" error if I do
This call never enters
If I do
however, I get
The same error occurs with
This disappears when the test is removed, of course. Are we not supposed to test to see if we are sending in these parameters in syn_spec for the
…ck for non-settable parameters in ConnBuilder::check_synapse_params_(). Regression test still failing when setting non-settable parameter at Connect on copy of stdp_dopamine_synpase.
@stinebuu The reason that