Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Moved check_synapse_params to specific synapse classes #739
This PR fixes #737 .
It takes each test in
A regressiontest is also added, which make sure all tests fail if we send in the specific parameters in the syn_spec dictionary.
@kappeld Could you review this pull request? Since it adds the method
Looks pretty good, I have just som comments that mainly concern documentation.
Great work! Much clearer now. I just have this one comment below, otherwise I am happy.
On a related note: Since the API of NEST has changed now quite a bit since the 2.12.0 release (with this and other changes), @heplesser are you planning to issue a 2.12.1 release soon? We would like to keep the version numbers of our custom module in sync with NEST's version number. Since the changes made to NEST also require a slightly updated version of our module to be compatible, making a new minor release might be more transparent for the users.