Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #748: For nest.helpdesk() Python 2.7.8 and later is needed #751

Merged
merged 5 commits into from Jun 13, 2017

Conversation

@steffengraber
Copy link
Collaborator

@steffengraber steffengraber commented Jun 13, 2017

This fix for #748 checks for the right Python version ( >= 2.7.8) when nest.helpdesk() is called.

python 2.7.8 and later is needed
@heplesser heplesser requested review from heplesser and janhahne Jun 13, 2017
Copy link
Contributor

@heplesser heplesser left a comment

@steffengraber Looks fine in principle, but I would change the message text. The same check also needs to be added to help().

@@ -63,6 +63,10 @@ def helpdesk():
Use the system default browser.
"""
if sys.version_info < (2, 7, 8):
print("You need python 2.7.8 or later to run this script.\n")

This comment has been minimized.

@heplesser

heplesser Jun 13, 2017
Contributor

I fear the user will be confused by "run this script". I would suggest

The NEST Helpdesk is only available with Python 2.7.8 or later.
@heplesser
Copy link
Contributor

@heplesser heplesser commented Jun 13, 2017

@steffengraber Would you add the "Py 2.7.8 required" message also to help()?

Copy link

@janhahne janhahne left a comment

Works fine, thank you for the quick fix 👍

@heplesser heplesser merged commit d64921c into nest:master Jun 13, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@steffengraber steffengraber deleted the steffengraber:fix-issue-748 branch Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.