Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Enable users to remove gid from filename in recording devices #760
with this PR I'd like to give the user more power over the filename of
I introduced a field called
I'm a bit sceptical that this change is a good idea. For example, what would happen if a user sets the same label for two devices on the same VP? Will NEST crash? Or will the data in the file be corrupted? I'm afraid that this leads to hard-to-debug errors as we can't easily guarantee that the labels are unique. Can you please test these kinds of situations and report back?
Also, the feature needs documentation in the SLI docstring of
RecordingDevice and possibly also somewhere in the NEST user manual.
For more general remarks on the code see my inline comments.
If a user sets the same label for different devices and sets
The data only gets corrupted, if the user sets
I understand your concerns and also see the possible risks in this feature but I think the user is well enough protected by being forced to give a label and by the