Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset python helper functions to make them work again #766

Merged
merged 4 commits into from Jun 29, 2017

Conversation

@hakonsbm
Copy link
Contributor

@hakonsbm hakonsbm commented Jun 23, 2017

This PR fixes issues introduced with #688, which made some of the PyNEST helper functions inoperable, and adds a Python regression test for these issues.

@@ -564,7 +564,7 @@ def set_verbosity(level):

# Defined in hl_api_helper to avoid circular inclusion problem with
# hl_api_info.py
sr
sr("%s setverbosity" % level)

This comment has been minimized.

@heplesser

heplesser Jun 24, 2017
Contributor

% string substitution is deprecated in Py3. Rather use '{} setverbosity'.format(level)

Copy link
Contributor

@heplesser heplesser left a comment

Just one tiny detail.

@heplesser heplesser requested a review from steffengraber Jun 26, 2017
@heplesser
Copy link
Contributor

@heplesser heplesser commented Jun 26, 2017

@steffengraber Could you take a look at this? The problematic changes from #688 were probably introduced by accident and I did not catch them when I reviewed your changes then.

Copy link
Contributor

@jougs jougs left a comment

Looks good to me. Thanks for fixing.

@jougs
jougs approved these changes Jun 29, 2017
@jougs jougs merged commit a721e62 into nest:master Jun 29, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hakonsbm hakonsbm deleted the hakonsbm:fix_py_verbosity branch Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.