New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset python helper functions to make them work again #766

Merged
merged 4 commits into from Jun 29, 2017

Conversation

Projects
None yet
3 participants
@hakonsbm
Contributor

hakonsbm commented Jun 23, 2017

This PR fixes issues introduced with #688, which made some of the PyNEST helper functions inoperable, and adds a Python regression test for these issues.

@heplesser

Just one tiny detail.

@heplesser heplesser requested a review from steffengraber Jun 26, 2017

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Jun 26, 2017

Contributor

@steffengraber Could you take a look at this? The problematic changes from #688 were probably introduced by accident and I did not catch them when I reviewed your changes then.

Contributor

heplesser commented Jun 26, 2017

@steffengraber Could you take a look at this? The problematic changes from #688 were probably introduced by accident and I did not catch them when I reviewed your changes then.

@jougs

Looks good to me. Thanks for fixing.

@jougs

jougs approved these changes Jun 29, 2017

@jougs jougs merged commit a721e62 into nest:master Jun 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hakonsbm hakonsbm deleted the hakonsbm:fix_py_verbosity branch Jun 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment