New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spin_detector precision and documentation fix #767

Merged
merged 7 commits into from Jul 7, 2017

Conversation

Projects
None yet
4 participants
@sepehrmn
Contributor

sepehrmn commented Jun 25, 2017

Fix for the first issue of #698. Precision was already there for some current or future use so I made it compatible with #446.

I'll fix the documentation of the spin_detector in a separate pull request. It got me thinking, maybe it could be made compatible with more than two states; a model I'm working on can have 4 states.

@sepehrmn

This comment has been minimized.

Show comment
Hide comment
@sepehrmn

sepehrmn Jun 26, 2017

Contributor

This can now be merged. Should be straightforward.

Contributor

sepehrmn commented Jun 26, 2017

This can now be merged. Should be straightforward.

@heplesser heplesser requested review from jougs and apeyser Jun 29, 2017

@jougs

Many thanks for the PR. I will approve and merge it once my comments are addressed.

Show outdated Hide outdated models/spin_detector.h
Show outdated Hide outdated models/spin_detector.h
Show outdated Hide outdated testsuite/unittests/test_spin_detector.sli
@sepehrmn

This comment has been minimized.

Show comment
Hide comment
@sepehrmn

sepehrmn Jun 29, 2017

Contributor

@jougs Many thanks for your comments. I'll address the issues over the weekend.

Contributor

sepehrmn commented Jun 29, 2017

@jougs Many thanks for your comments. I'll address the issues over the weekend.

@sepehrmn

This comment has been minimized.

Show comment
Hide comment
@sepehrmn

sepehrmn Jul 2, 2017

Contributor

@jougs I have addressed all issues and wrote full documentation for the device as it was copy pasted from another device. This can now be merged.

Contributor

sepehrmn commented Jul 2, 2017

@jougs I have addressed all issues and wrote full documentation for the device as it was copy pasted from another device. This can now be merged.

@sepehrmn sepehrmn changed the title from Spin_detector precision to Spin_detector precision and documentation fix Jul 2, 2017

@jougs

jougs approved these changes Jul 5, 2017

Many thanks for addressing my issues.

@jougs

This comment has been minimized.

Show comment
Hide comment
@jougs

jougs Jul 7, 2017

Contributor

@apeyser: most of the functionality touched here will have to be re-implemented in NESTio. Can I just merge this now and we review it anew when merging the nestio branch back to master?

Contributor

jougs commented Jul 7, 2017

@apeyser: most of the functionality touched here will have to be re-implemented in NESTio. Can I just merge this now and we review it anew when merging the nestio branch back to master?

@apeyser

This comment has been minimized.

Show comment
Hide comment
@apeyser

apeyser Jul 7, 2017

Contributor

@jougs: sounds reasonable.

Contributor

apeyser commented Jul 7, 2017

@jougs: sounds reasonable.

@jougs

This comment has been minimized.

Show comment
Hide comment
@jougs

jougs Jul 7, 2017

Contributor

@apeyser: thanks. Merging.

Contributor

jougs commented Jul 7, 2017

@apeyser: thanks. Merging.

@jougs jougs merged commit bb3cafe into nest:master Jul 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment