Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test if NDEBUG is set #770

Merged
merged 2 commits into from Jul 31, 2017
Merged

Skip test if NDEBUG is set #770

merged 2 commits into from Jul 31, 2017

Conversation

@jougs
Copy link
Contributor

@jougs jougs commented Jun 29, 2017

This fixes #272.

@jougs jougs requested review from heplesser and gtrensch Jun 29, 2017
@jougs jougs added this to the NEST 2.12.1 milestone Jun 29, 2017
Copy link
Contributor

@heplesser heplesser left a comment

Neat solution, but I think you changed more than needed, see inline comment.

@@ -493,7 +493,8 @@ CODES_FAILURE=\

run_test selftests/test_fail_or_die.sli "${CODES_SUCCESS}" "${CODES_SKIPPED}" "${CODES_FAILURE}"

CODES_SUCCESS=' 3 Success'
CODES_SUCCESS=' 3 Success,'\
' 200 Skipped,'

This comment has been minimized.

@heplesser

heplesser Jun 29, 2017
Contributor

Skipping is not success. I think CODES_SUCCESS should remain unchanged. The 200 exit code from the script will then be registered and reported as a skipped test. CODES_SKIPPED is defined for the entire file around line 435.

@jougs
Copy link
Contributor Author

@jougs jougs commented Jun 29, 2017

Ah, OK. Then I misunderstood how skipping works. I've reverted my changes to testsuite/do_tests.sh.in in b3eeb7c.

@gtrensch
Copy link
Collaborator

@gtrensch gtrensch commented Jul 11, 2017

Tested and approved !

@heplesser heplesser merged commit 271d59f into nest:master Jul 31, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.