New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test if NDEBUG is set #770

Merged
merged 2 commits into from Jul 31, 2017

Conversation

Projects
None yet
3 participants
@jougs
Contributor

jougs commented Jun 29, 2017

This fixes #272.

@jougs jougs requested review from heplesser and gtrensch Jun 29, 2017

@jougs jougs added this to the NEST 2.12.1 milestone Jun 29, 2017

@heplesser

Neat solution, but I think you changed more than needed, see inline comment.

Show outdated Hide outdated testsuite/do_tests.sh.in Outdated
@jougs

This comment has been minimized.

Show comment
Hide comment
@jougs

jougs Jun 29, 2017

Contributor

Ah, OK. Then I misunderstood how skipping works. I've reverted my changes to testsuite/do_tests.sh.in in b3eeb7c.

Contributor

jougs commented Jun 29, 2017

Ah, OK. Then I misunderstood how skipping works. I've reverted my changes to testsuite/do_tests.sh.in in b3eeb7c.

@gtrensch

This comment has been minimized.

Show comment
Hide comment
@gtrensch

gtrensch Jul 11, 2017

Contributor

Tested and approved !

Contributor

gtrensch commented Jul 11, 2017

Tested and approved !

@heplesser heplesser merged commit 271d59f into nest:master Jul 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment