New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in GetStructrualPlasticityStatus format #775

Merged
merged 7 commits into from Jul 11, 2017

Conversation

Projects
None yet
3 participants
@sdiazpier
Contributor

sdiazpier commented Jul 2, 2017

This PR addresses issue #260 by changing the call format for GetStructuralPlasticityStatus. Now the parameter for the call is optional and can include a string defining the elements of interest from the status dictionary. The call still returns the dictionary containing the status filtered by the parameter string. A small test was also added.

@heplesser

@sdiazpier Thank you for your pull request! I have commented on a few issues; you also need to fix a number of PEP8 issues to make Travis happy.

Show outdated Hide outdated pynest/nest/lib/hl_api_simulation.py
Show outdated Hide outdated pynest/nest/lib/hl_api_simulation.py
if keys is None:
return d
elif is_literal(keys):
return d[keys]

This comment has been minimized.

@heplesser

heplesser Jul 2, 2017

Contributor

Here, keys can only be a single key, so why the plural? And wouldn't it make more sense to allow a list of keys, as in GetStatus?

@heplesser

heplesser Jul 2, 2017

Contributor

Here, keys can only be a single key, so why the plural? And wouldn't it make more sense to allow a list of keys, as in GetStatus?

This comment has been minimized.

@sdiazpier

sdiazpier Jul 2, 2017

Contributor

I left it plural but allow now a list like in GetStatus :)

@sdiazpier

sdiazpier Jul 2, 2017

Contributor

I left it plural but allow now a list like in GetStatus :)

Show outdated Hide outdated pynest/nest/lib/hl_api_simulation.py
Show outdated Hide outdated pynest/nest/tests/test_sp/test_all.py
Show outdated Hide outdated pynest/nest/tests/test_sp/test_get_sp_status.py
Show outdated Hide outdated pynest/nest/tests/test_sp/test_get_sp_status.py

@heplesser heplesser requested a review from jakobj Jul 2, 2017

@heplesser heplesser added this to the NEST 2.12.1 milestone Jul 2, 2017

@heplesser

@sdiazpier I approve, conditional on Travis passing. Problems there all seem to be PEP8 issues, mostly due to tabs instead of spaces.

@abigailm

just a typo, otherwise lgtm

@abigailm abigailm merged commit bbcdd91 into nest:master Jul 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment