Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit DataConnect in multithreaded mode. #776

Merged
merged 2 commits into from Jul 3, 2017

Conversation

@stinebuu
Copy link
Contributor

@stinebuu stinebuu commented Jul 3, 2017

This PR fixes #527. I have added a check to see if we have more than one thread when using DataConnect, in which case an exception is thrown. I have also added a simple regressiontest.

@heplesser heplesser requested a review from Silmathoron Jul 3, 2017
Copy link
Contributor

@heplesser heplesser left a comment

@stinebuu Thanks! Just a few tiny details.

if ( kernel().vp_manager.get_num_threads() > 1 )
{
throw KernelException(
"DataConnect can not be used with multiple threads" );

This comment has been minimized.

@heplesser

heplesser Jul 3, 2017
Contributor

cannot

if ( kernel().vp_manager.get_num_threads() > 1 )
{
throw KernelException(
"DataConnect can not be used with multiple threads" );

This comment has been minimized.

@heplesser

heplesser Jul 3, 2017
Contributor

cannot

{
dup /threads Set
ResetKernel
0 << /local_num_threads threads /total_num_virtual_procs threads >> SetStatus

This comment has been minimized.

@heplesser

heplesser Jul 3, 2017
Contributor

No need to set total_num_virtual_procs, that is set automatically based on local_num_threads.

Copy link
Member

@Silmathoron Silmathoron left a comment

@heplesser you're making me read sli tests ?!? ^^
All looks good 👍

@heplesser
Copy link
Contributor

@heplesser heplesser commented Jul 3, 2017

Release notes: DataConnect is now prohibited in multi-threaded mode because it is unstable, see #527.

@heplesser heplesser merged commit cdbbe3c into nest:master Jul 3, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stinebuu stinebuu deleted the stinebuu:issue527-segFault_dataConnect branch Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.