New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit DataConnect in multithreaded mode. #776

Merged
merged 2 commits into from Jul 3, 2017

Conversation

Projects
None yet
3 participants
@stinebuu
Contributor

stinebuu commented Jul 3, 2017

This PR fixes #527. I have added a check to see if we have more than one thread when using DataConnect, in which case an exception is thrown. I have also added a simple regressiontest.

@heplesser heplesser requested a review from Silmathoron Jul 3, 2017

@heplesser

@stinebuu Thanks! Just a few tiny details.

Show outdated Hide outdated nestkernel/nestmodule.cpp
Show outdated Hide outdated nestkernel/nestmodule.cpp
Show outdated Hide outdated testsuite/regressiontests/issue-527.sli
@Silmathoron

@heplesser you're making me read sli tests ?!? ^^
All looks good 👍

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Jul 3, 2017

Contributor

Release notes: DataConnect is now prohibited in multi-threaded mode because it is unstable, see #527.

Contributor

heplesser commented Jul 3, 2017

Release notes: DataConnect is now prohibited in multi-threaded mode because it is unstable, see #527.

@heplesser heplesser merged commit cdbbe3c into nest:master Jul 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stinebuu stinebuu deleted the stinebuu:issue527-segFault_dataConnect branch Jul 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment