New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major change in the installation and testing of packages using multiple python versions #789

Merged
merged 64 commits into from Apr 18, 2018

Conversation

Projects
None yet
7 participants
@lekshmideepu
Contributor

lekshmideepu commented Jul 20, 2017

This PR consists of a number of changes in the installation and testing processes:

  1. Using multiple python versions. #763
  2. Using the container based whitelist packages from Travis. #758
  3. Explicitly defining the CMake options as the system unable to recognise the python libraries.
  4. Some code changes to adapt to both python2 and python3
  5. Moved the package (cppcheck and CLANG_FORMAT) installation from build.sh to yaml. #759
  6. Changes in the message passing numbers for the parse log.
Using the container based infrastructure build for trusty using the t…
…ravis python images,multiple python versions

@lekshmideepu lekshmideepu requested a review from jougs Jul 20, 2017

@jougs

Many thanks for this contribution. I have added several questions and comments, which I'd like to have answered before approving a merge.

Show outdated Hide outdated .travis.yml
Show outdated Hide outdated build.sh
Show outdated Hide outdated testsuite/regressiontests/ticket-659-copyright.py
Show outdated Hide outdated music_install.sh
Show outdated Hide outdated pynest/nest/tests/test_sp/test_disconnect.py
@Silmathoron

Silmathoron suggested changes Jul 26, 2017 edited

Hey @lekshmideepu Thanks for trying to make the travis tests compatible with Py2/3.
However, some sections of the travis file seem to do the same thing, or to make the other unnecessary, at least from my point of view...

Could you clarify:

  1. the necessity of the deprecated branch,
  2. the problems with scipy and exactly which version you want (looks like in the end you use that of pip),
  3. why you do not use the include keyword in matrix?
Show outdated Hide outdated .travis.yml
Show outdated Hide outdated .travis.yml
Show outdated Hide outdated .travis.yml
Show outdated Hide outdated build.sh
Show outdated Hide outdated music_install.sh
Show outdated Hide outdated build.sh
@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Aug 9, 2017

Contributor

See also #619

Contributor

heplesser commented Aug 9, 2017

See also #619

@jougs

This comment has been minimized.

Show comment
Hide comment
@jougs

jougs Sep 20, 2017

Contributor

@lekshmideepu, @sdiazpier: Would it be possible / make sense to factor out the part fixing the MPI problems in test_disconnect.py and create another pull request from them? They are more or less independent of the changes to the CI setup, aren't they? Thanks!

Contributor

jougs commented Sep 20, 2017

@lekshmideepu, @sdiazpier: Would it be possible / make sense to factor out the part fixing the MPI problems in test_disconnect.py and create another pull request from them? They are more or less independent of the changes to the CI setup, aren't they? Thanks!

@sdiazpier

This comment has been minimized.

Show comment
Hide comment
@sdiazpier

sdiazpier Sep 20, 2017

Contributor

@lekshmideepu and @jougs I just started a new pull request with the changes that @lekshmideepu implemented in this PR to solve the issue with the testing of synapse deletion using mpi and pynest. @lekshmideepu could you please remove the modification in this PR?

Contributor

sdiazpier commented Sep 20, 2017

@lekshmideepu and @jougs I just started a new pull request with the changes that @lekshmideepu implemented in this PR to solve the issue with the testing of synapse deletion using mpi and pynest. @lekshmideepu could you please remove the modification in this PR?

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Oct 30, 2017

Contributor

@lekshmideepu It would be extremely useful to get this PR merged. Could you fix the remaining issues in the near future?

Contributor

heplesser commented Oct 30, 2017

@lekshmideepu It would be extremely useful to get this PR merged. Could you fix the remaining issues in the near future?

@lekshmideepu

This comment has been minimized.

Show comment
Hide comment
@lekshmideepu

lekshmideepu Apr 5, 2018

Contributor

@Silmathoron : include syntax doesn't triggered a travis build. That is why I changed it.

Contributor

lekshmideepu commented Apr 5, 2018

@Silmathoron : include syntax doesn't triggered a travis build. That is why I changed it.

@Silmathoron

Ok, that's weird... it works on my travis, but let's not drag on this: it works, so fine with me! 👍

@lekshmideepu

This comment has been minimized.

Show comment
Hide comment
@lekshmideepu

lekshmideepu Apr 9, 2018

Contributor

@Silmathoron : Thanks. Probably I would try the matrix include in another PR once this is merged.

Contributor

lekshmideepu commented Apr 9, 2018

@Silmathoron : Thanks. Probably I would try the matrix include in another PR once this is merged.

@lekshmideepu

This comment has been minimized.

Show comment
Hide comment
@lekshmideepu

lekshmideepu Apr 10, 2018

Contributor

@jougs : Could you please take a look again?

Contributor

lekshmideepu commented Apr 10, 2018

@jougs : Could you please take a look again?

@jougs

Many thanks for taking care of all concerns and sorry for the long delay to re-review.

I have added some specific minor comments in the code. While I like the splitting of the installation of third-party software into separate scripts very much, I still have one small request concerning them: Can you please rename the *_install.sh scripts to install_*.sh and move them to the extras directory? I think that they might cause confusion in the root directory and the rename makes sure they appear in alphabetical order.

Show outdated Hide outdated .travis.yml
Show outdated Hide outdated .travis.yml
Show outdated Hide outdated build.sh
Show outdated Hide outdated build.sh
Show outdated Hide outdated pynest/nest/tests/test_sp/test_disconnect.py
@lekshmideepu

This comment has been minimized.

Show comment
Hide comment
@lekshmideepu

lekshmideepu Apr 16, 2018

Contributor

@jougs :Thanks for the comments. Hope I have answered all of them.

Contributor

lekshmideepu commented Apr 16, 2018

@jougs :Thanks for the comments. Hope I have answered all of them.

@jougs

Many thanks for the fixes. I've sent you a small pull request with some additions and the deletion of the old installation scripts. I'll approve and merge this one once you have added the changes from my PR.

Merge pull request #2 from jougs/trustycontainer
Remove old versions of scripts and small cleanup
@jougs

jougs approved these changes Apr 17, 2018

Very nice! I really appreciate these changes very much and am sure they will help us quite a bit in the future.

@lekshmideepu

This comment has been minimized.

Show comment
Hide comment
@lekshmideepu

lekshmideepu Apr 18, 2018

Contributor

@jougs : Thanks!

Contributor

lekshmideepu commented Apr 18, 2018

@jougs : Thanks!

@apeyser apeyser merged commit 8aa6d50 into nest:master Apr 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment