Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execution of MPI-enabled SP tests #799

Merged
merged 3 commits into from Aug 7, 2017
Merged

Fix execution of MPI-enabled SP tests #799

merged 3 commits into from Aug 7, 2017

Conversation

@jougs
Copy link
Contributor

jougs commented Aug 3, 2017

This fixes #791 by using the absolute path of the script in the invocation of python. It also handles skipped tests properly in our custom Python test harness.

@jougs jougs requested review from heplesser and sdiazpier Aug 3, 2017
Copy link
Contributor

heplesser left a comment

Looks good as a fix for the current issue. I am not really happy, though, with the way in which we here "highjack" the suite() method to run MPI tests. But we can get back to that once we have come to a conclusion on #761.

@jougs jougs added this to the NEST 2.12.1 milestone Aug 7, 2017
@jougs jougs requested review from gtrensch and removed request for sdiazpier Aug 7, 2017
@gtrensch
Copy link
Collaborator

gtrensch commented Aug 7, 2017

Looks good to me, even though there are lines longer than 80. (*.py.in will not run through the PEP8 check) I'm entirely happy with this. Approved!

@heplesser heplesser merged commit ebe26d0 into nest:master Aug 7, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.