Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude files starting with ".#" from help generation #802

merged 1 commit into from Aug 7, 2017


Copy link

jakobj commented Aug 6, 2017

If these files exist and are not excluded, the help generation fails:

Traceback (most recent call last):                                                                                                              
  File "", line 95, in <module>                                                                                        
    f = open(fname, 'r')                                                                        
FileNotFoundError: [Errno 2] No such file or directory: '/home/jordan/opt/nest-private/nestkernel/.#kernel_manager.cpp'
doc/CMakeFiles/generate_help.dir/build.make:57: recipe for target 'generate_help' failed                                  
make[2]: *** [generate_help] Error 1                                                                                     
CMakeFiles/Makefile2:247: recipe for target 'doc/CMakeFiles/generate_help.dir/all' failed    
make[1]: *** [doc/CMakeFiles/generate_help.dir/all] Error 2                                                                                                                                                                                                                                
make[1]: *** Waiting for unfinished jobs....

This PR fixes this.

Copy link

heplesser left a comment

@jakobj I will approve this as soon as you fix the PEP8 problem and Travis is happy.

@jakobj jakobj force-pushed the jakobj:bug/exclude_backup_files branch from 7e992f7 to a5ec795 Aug 7, 2017
Copy link
Contributor Author

jakobj commented Aug 7, 2017

fixed, rebased and pushed. thanks for the fast review @heplesser

jougs approved these changes Aug 7, 2017
Copy link

jougs left a comment

I'm approving and merging, although I somehow liked the implicit reminder that I still had unsaved files in emacs when running make ;-)

@jougs jougs merged commit b0ea450 into nest:master Aug 7, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.