Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit module installation after CopyModel (fixes #746) #804

Merged
merged 1 commit into from Aug 7, 2017

Conversation

@heplesser
Copy link
Contributor

@heplesser heplesser commented Aug 7, 2017

This PR fixes #746. It does not contain a regression test, since that would require building MyModule, which is currently not supported by our test harness. I will create a separate issue for that.

@heplesser heplesser added this to the NEST 2.12.1 milestone Aug 7, 2017
@heplesser heplesser requested review from jougs and gtrensch Aug 7, 2017
@jougs
jougs approved these changes Aug 7, 2017
@gtrensch
Copy link
Collaborator

@gtrensch gtrensch commented Aug 7, 2017

Looks good to me.

@jougs jougs merged commit b6345cc into nest:master Aug 7, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@heplesser heplesser deleted the heplesser:fix-746-module-loading branch Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.