Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in test_connect_all_patterns.py with mpirun #807

Merged
merged 6 commits into from Oct 30, 2017

Conversation

@hakonsbm
Copy link
Contributor

@hakonsbm hakonsbm commented Aug 15, 2017

The test test_connect_all_patterns.py now uses mpirun to run the tests

  • test_connect_all_to_all.py
  • test_connect_one_to_one.py
  • test_connect_fixed_indegree.py
  • test_connect_fixed_outdegree.py
  • test_connect_fixed_total_number.py
  • test_connect_pairwise_bernoulli.py

This fixes #353.

@hakonsbm hakonsbm changed the title Test connect all mpirun Run tests in test_connect_all_patterns.py with mpirun Aug 15, 2017
@heplesser heplesser requested review from jougs and heplesser Aug 21, 2017
Copy link
Contributor

@heplesser heplesser left a comment

@hakonsbm When I run your branch on my computer, several tests fail. I am not quite sure what is going on. the test logs on Travis do not show any TestConnectAllPatterns tests. I am not sure what is going on.

]
retcodes = []
for script in scripts:
test_script = directory + "/" + script

This comment has been minimized.

@heplesser

heplesser Aug 23, 2017
Contributor

Use os.path.join() to combine directory and script

@hakonsbm
Copy link
Contributor Author

@hakonsbm hakonsbm commented Aug 25, 2017

@heplesser The test will now be skipped if it's unable to import mpi4py. Additionally, there are some problems if using Anaconda and installing mpi4py with conda, as this will also install MPICH, making several of the SLI MPI tests fail. One way to avoid this is to install mpi4py using pip.

@jougs
jougs approved these changes Sep 4, 2017
Copy link
Contributor

@jougs jougs left a comment

Thanks for the contribution. The code looks good to me although we should probably have a unified solution for this in the future instead of duplicating this or similar functionality in multiple files. I've added this PR to our project about Python test frameworks

@heplesser
Copy link
Contributor

@heplesser heplesser commented Sep 4, 2017

@jougs All fine from my side. Since it is not 100% clear to me whether your last comment means "wait" or "merge", I'll leave the merge to you.

@heplesser heplesser merged commit 04726d9 into nest:master Oct 30, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hakonsbm hakonsbm deleted the hakonsbm:test_connect_all_mpirun branch Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.