New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let iaf_psc_exp_ps handle simultaneous spikes independently. Fixes #368. #810

Merged
merged 1 commit into from Aug 25, 2017

Conversation

Projects
None yet
3 participants
@heplesser
Contributor

heplesser commented Aug 21, 2017

I intentionally made accumulate_simultaneous the second argument of get_next_spike(), even though making it the last would have allowed me to use the default value true. But I thought it would be cleaner to have the two parameters specifying what to get first, followed by the three parameters passing the return values.

@heplesser heplesser added this to the NEST 2.12.1 milestone Aug 21, 2017

@heplesser heplesser requested a review from jougs Aug 21, 2017

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Aug 21, 2017

Contributor

@apdavison At long last a fix for your issue #368. Would you be willing and able to review it? We would like to include the fix in the NEST 2.12.1 release.

Contributor

heplesser commented Aug 21, 2017

@apdavison At long last a fix for your issue #368. Would you be willing and able to review it? We would like to include the fix in the NEST 2.12.1 release.

@apdavison

This comment has been minimized.

Show comment
Hide comment
@apdavison

apdavison Aug 24, 2017

I've installed your branch locally, and I now get the same behaviour for iaf_psc_exp_ps and iaf_psc_exp, so this looks good to me.

apdavison commented Aug 24, 2017

I've installed your branch locally, and I now get the same behaviour for iaf_psc_exp_ps and iaf_psc_exp, so this looks good to me.

@jougs

jougs approved these changes Aug 25, 2017

The code looks good to me. Given that it works for @apdavison, I'll merge immediately. Thanks for taking care of this.

@jougs jougs merged commit 672aa40 into nest:master Aug 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@heplesser heplesser deleted the heplesser:fix-368-psc_exp_ps branch Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment