Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binary_neuron_impl.h #813

Merged
merged 1 commit into from Aug 24, 2017
Merged

Conversation

@jakobj
Copy link
Contributor

@jakobj jakobj commented Aug 24, 2017

Since the _impl.h file provides required definitions of template functions, it always needs to be included along with the .h file. To avoid having two seperate files for the definition of the binary_neuron template, all functions are moved to the .h file.
This followed from the discussion in #492, I suggest @heplesser and @jougs as reviewers.

Since the _impl.h file provides required definitions of template
functions, it always needs to be included along with the .h
file. To avoid having two seperate files for the definition of the
binary_neuron template, all functions are moved to the .h file.
@jakobj jakobj force-pushed the jakobj:fix/remove_binary_neuron_impl branch from f940cd7 to e580b59 Aug 24, 2017
@heplesser heplesser requested review from heplesser and jougs Aug 24, 2017
Copy link
Contributor

@heplesser heplesser left a comment

@jakobj Thank you and approved, conditional on Travis passing.

@heplesser heplesser mentioned this pull request Aug 24, 2017
@jougs
jougs approved these changes Aug 24, 2017
Copy link
Contributor

@jougs jougs left a comment

Thanks and merging!

@jougs jougs merged commit b5531c9 into nest:master Aug 24, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.