Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix #740 by representing times in steps in step_current_generator. #815
jougs left a comment
Other than my tiny comment on indentation the code looks good to me.
Can you please add a short explanation on why we need the
@jougs One use case would be that the user uses random numbers for the times at which amplitudes change. These would not most likely not fall onto the grid. As a convenience for the user, NEST can round these times, but it should only do this if explicitly requested to avoid subtle errors otherwise.
Should I put this into the inline documentation, or did you just want an explanation here in the discussion?