New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure number of vacant synaptic elements is always >= 0 #818

Merged
merged 1 commit into from Sep 18, 2017

Conversation

Projects
None yet
3 participants
@sanjayankur31
Contributor

sanjayankur31 commented Sep 5, 2017

Minor check to ensure that the number of vacant synaptic elements is
always >= 0. When synaptic elements are to be deleted, z_ <
z_connected_, and in this scenario, this method may return a negative -
which when passed to the decay_synaptic_elements method unexpectedly
adds to the z_ value instead of having no effect (there are no
vacant elements to decay).

The decay method is only called after connectivity updates have been
made in the current source, so this issue doesn not arise. However, as
we're thinking of moving towards decoupling the structural plasticity
updates in the future, this general check is worth adding.

(Discussed this with @sdiazpier over slack and we thought it'd be better to have the check in now than diagnose unexpected behaviours later.)

Ensure number of vacant synaptic elements is always >= 0
Minor check to ensure that the number of vacant synaptic elements is
always >= 0. When synaptic elements are to be deleted, z_ <
z_connected_, and in this scenario, this method may return a negative -
which when passed to the `decay_synaptic_elements` method unexpectedly
adds to the z_ value instead of having no effect (there are no
vacant elements to decay).

The decay method is only called after connectivity updates have been
made in the current source, so this issue doesn not arise. However, as
we're thinking of moving towards decoupling the structural plasticity
updates in the future, this general check is worth adding.
@sdiazpier

This comment has been minimized.

Show comment
Hide comment
@sdiazpier

sdiazpier Sep 5, 2017

Contributor

Approved on my side 👍

Contributor

sdiazpier commented Sep 5, 2017

Approved on my side 👍

@terhorstd terhorstd requested a review from sdiazpier Sep 18, 2017

@terhorstd terhorstd merged commit f6959c3 into nest:master Sep 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment