New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set the environment variables for do_tests.sh #819

Merged
merged 1 commit into from Sep 6, 2017

Conversation

Projects
None yet
3 participants
@jougs
Contributor

jougs commented Sep 6, 2017

This changes the custom build target installcheck to only set the configuration-specific part of the environment variables PATH and PYTHONPATH. The bash script do_tests.sh then concatenates these with the real environment variables.

The way it was done before did not actually work, but was setting the variables to the values at
configure time, instead of build time.

This fixes #817.

Properly set the environment variables for do_tests.sh
This changes the custom build target installcheck to only set the
configuration-specific part of the environment variables PATH and
PYTHONPATH. The bash script do_tests.sh then concatenates these
with the real environment variable. The way it was done before did
not actually work, but was setting the variables to the values at
configure time, instead of build time.

This fixes #817.
@stinebuu

This seems good to me.

@jougs jougs merged commit 7877c87 into nest:master Sep 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment