New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with iaf_psc_delta_canon and test_dcgen_vs_I_e.sli #822

Merged
merged 3 commits into from Oct 16, 2017

Conversation

Projects
None yet
3 participants
@heplesser
Contributor

heplesser commented Sep 7, 2017

This fixes a problem reported by SDSC in which test_dcgen_vs_I_e.sli fails for iaf_psc_delta_canon for certain hardware/compiler combinations. The failure is due to the fact that that model treated I_e and injected current slightly differently. This PR ensures that both forms of current input are treated perfectly symmetrical (always appear as sum P_.I_e_ + S_.I_).

It also tidies up the test code and removes calls to executive, which put SLI into interactive mode in case of a test failure.

@jougs I will ask someone from SDSC to review as well. Since this is a straightforward fix, I add it to 2.14.

@heplesser heplesser added this to the NEST 2.14.0 milestone Sep 7, 2017

@heplesser heplesser requested a review from jougs Sep 7, 2017

@heplesser heplesser requested a review from hakonsbm Sep 27, 2017

@hakonsbm

The code looks good to me. Just a couple misspelled words in the original iaf_psc_delta_canon.cpp that you can fix if you want to

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Sep 27, 2017

Contributor

Fixed typos as requested by @hakonsbm .

Contributor

heplesser commented Sep 27, 2017

Fixed typos as requested by @hakonsbm .

@jougs

jougs approved these changes Oct 16, 2017

Looks good. Thanks!

@jougs jougs merged commit c9d9325 into nest:master Oct 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@heplesser heplesser deleted the heplesser:fix-test_dc_ie branch Aug 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment