New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce primary_end_ marker for het connections #834

Merged
merged 3 commits into from Oct 12, 2017

Conversation

Projects
None yet
5 participants
@sanjayankur31
Contributor

sanjayankur31 commented Oct 1, 2017

When all connections of a particular synapse type are removed, the
entry is removed from HetConnector and the primary_end_ marker should
also be reduced by one.

Fixes #832

This may not be the best way of going about fixing the issue. Someone with more knowledge of the connection data structures should take a look and modify it keeping the code design in mind.

Reduce primary_end_ marker for het connections
When all connections of a particular synapse type are removed, the
entry is removed from HetConnector and the primary_end_ marker should
also be reduced by one.

Fixes #832
@janhahne

@sanjayankur31 Thanks a lot for the fix! I send you a pull request with a regression test that ensures that this bug is fixed in a setup with additional gap junctions.

Once this is added I am all happy 👍

@jakobj This might be something that is important for future architecture as well. The new regression test will hopefully ensure that the bug is detected if it also applies there.

@jakobj

This comment has been minimized.

Show comment
Hide comment
@jakobj

jakobj Oct 12, 2017

Contributor

looks good to me 👍 will keep it in mind for future changes :)

Contributor

jakobj commented Oct 12, 2017

looks good to me 👍 will keep it in mind for future changes :)

@jakobj

jakobj approved these changes Oct 12, 2017

@terhorstd terhorstd merged commit ff33e38 into nest:master Oct 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment