New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow negative exponential distributions (fixes #835) #836

Merged
merged 4 commits into from Feb 6, 2018

Conversation

Projects
None yet
3 participants
@luis-rr
Contributor

luis-rr commented Oct 4, 2017

Some models rely on the synaptic weight being negative in order to consider the synapse inhibitory.
However the exponential distribution wasn't allowing a negative lambda value.
With this change we can generate exponential distributions of inhibitory synaptic weights.

Note that the implementation in librandom/exp_randomdev.h already works for negative lambda values, this is just removing the check for negative parameter values.

Luis Riquelme
allow negative exponential distributions
Some models rely on the synaptic weight being negative in order to consider the synapse inhibitory.
However the exponential distribution wasn't allowing a negative lambda value.
With this change we can generate exponential distributions of inhibitory synaptic weights.

Note that the implementation in librandom/exp_randomdev.h already works for negative lambda values.
@heplesser

@luis-rr Thank you for your PR! Your changes look fine, but the documentation needs to be updated to reflect that negative lambda are now allowed (in the header file, |lambda| in the exponential).

@heplesser heplesser changed the title from Allow negative exponential distributions to Allow negative exponential distributions (fixes #835) Oct 6, 2017

@heplesser

This comment has been minimized.

Show comment
Hide comment
@heplesser

heplesser Oct 6, 2017

Contributor

Please also send me a signed contributor license agreement (see http://nest.github.io/nest-simulator/index) by direct email.

Contributor

heplesser commented Oct 6, 2017

Please also send me a signed contributor license agreement (see http://nest.github.io/nest-simulator/index) by direct email.

@heplesser

The code is fine now, just one little formatting issue to fix to make Travis happy. Thanks!

@jougs

jougs approved these changes Feb 6, 2018

Thanks for the contribution and sorry for the long delay. I'm merging without further ado.

@jougs jougs merged commit a7ffee9 into nest:master Feb 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment